nodejs: Install npm manpages #56226
Merged
nodejs: Install npm manpages #56226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +97,12 @@ in | |||
| ${optionalString enableNpm '' | |||
| mkdir -p $out/share/bash-completion/completions/ | |||
| $out/bin/npm completion > $out/share/bash-completion/completions/npm | |||
| for dir in "$out/lib/node_modules/npm/man/"*; do | |||
There was a problem hiding this comment.
You might be able to just do mkdir -p $out/share/ && ln -s $out/lib/node_modules/npm/man $out/share/man
There was a problem hiding this comment.
unfortunately is not going to work, because node ships node(1) manpage
$ exa -T result/share/man
result/share/man
└── man1
└── node.1.gz
and with this PR I want to add the npm remaining manpages from npm
$ exa -T result/share/man
result/share/man
├── man1
│ ├── node.1.gz
│ ├── npm-access.1 -> ../../../lib/node_modules/npm/man/man1/npm-access.1
| ⋮
│ ├── npm.1 -> ../../../lib/node_modules/npm/man/man1/npm.1
│ └── npx.1 -> ../../../lib/node_modules/npm/man/man1/npx.1
├── man5
│ ├── npm-folders.5 -> ../../../lib/node_modules/npm/man/man5/npm-folders.5
| ⋮
│ └── package.json.5 -> ../../../lib/node_modules/npm/man/man5/package.json.5
└── man7
├── npm-coding-style.7 -> ../../../lib/node_modules/npm/man/man7/npm-coding-style.7
⋮
├── removing-npm.7 -> ../../../lib/node_modules/npm/man/man7/removing-npm.7
└── semver.7 -> ../../../lib/node_modules/npm/man/man7/semver.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)