Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mycli: patch tests #57718

Merged
merged 1 commit into from Mar 15, 2019
Merged

mycli: patch tests #57718

merged 1 commit into from Mar 15, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 15, 2019 •
edited

Motivation for this change

Similar to f3c66bb. Due to invalid
datatypes a lot of the tests broke.

The patch is based on an upstream PR[1], but had to be modified in order
to apply on v1.19.0.

See also https://hydra.nixos.org/build/90119741
Addresses #56826

[1] dbcli/mycli#711

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
mycli: patch tests
69c21be 
Similar to f3c66bb. Due to invalid
datatypes a lot of the tests broke.

The patch is based on an upstream PR[1], but had to be modified in order
to apply on v1.19.0.

See also https://hydra.nixos.org/build/90119741
Addresses NixOS#56826

[1] dbcli/mycli#711
@xeji xeji merged commit a2187b4 into NixOS:master Mar 15, 2019
@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

backported in d9da434

@Ma27 Ma27 deleted the fix-mycli branch March 15, 2019 21:30
@Ma27 Ma27 mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg