Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp: 2.3.3 -> 2.4.0 #57669

Merged
merged 1 commit into from Mar 17, 2019
Merged

libseccomp: 2.3.3 -> 2.4.0 #57669

merged 1 commit into from Mar 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 14, 2019

Motivation for this change

https://github.com/seccomp/libseccomp/releases/tag/v2.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Have not build-tested this "yet",
due to triggering so many rebuilds.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 15, 2019

Using this presently, FWIW :).

@dtzWill
Copy link
Member Author

dtzWill commented Mar 15, 2019

https://www.openwall.com/lists/oss-security/2019/03/15/1

cc @NixOS/backports (ping is premature, but don't want to forget!)

@xeji xeji mentioned this pull request Mar 16, 2019
Closed
thoughtpolice
thoughtpolice approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dtzWill dtzWill merged commit c10dfbc into NixOS:staging Mar 17, 2019
@dtzWill dtzWill deleted the update/libseccomp-2.4.0 branch March 17, 2019 05:47
lheckemann pushed a commit that referenced this pull request Mar 17, 2019
@dtzWill @lheckemann
libseccomp: 2.3.3 -> 2.4.0
1b9fbe0 
https://github.com/seccomp/libseccomp/releases/tag/v2.4.0
(cherry picked from commit 862ea07)
PR #57669
@lheckemann
Copy link
Member

Backported to staging-19.03: 1b9fbe0

@stefano-m
Copy link
Contributor

@lheckemann shouldn't this be backported to 18.09 too or has the release of 19.03 ended support for the 18.09?

@lheckemann
Copy link
Member

lheckemann commented Apr 18, 2019 •
edited

Yes, it probably should. Nevertheless, I don't know when exactly support for 18.09 ends, but it will be soon. Maybe @samueldr has a plan?

(backported: de627cd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @lheckemann @stefano-m @thoughtpolice @GrahamcOfBorg