Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Animation Worklet] Migrate animator state to new global scope #15848

Merged
merged 1 commit into from Apr 5, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 14, 2019

Major changes:

  • Consolidate stateful global scope and stateless global scope. i.e.
    only select one global scope randomly upon mutation.
  • No longer create animator instances on both global scopes. Instead,
    create one instance on the selected global scope and upon switching
    global scopes create a new one on the new global scope with all the
    properties transferred. For stateful animators, the state gets
    transferred as well.

Bug: 914918
Change-Id: I13837eb787dcc671492e8c5fbba6176a3bf34cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488312
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648282}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1488312 branch 4 times, most recently from bf7846b to d4a53b5 Compare March 26, 2019 16:47
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1488312 branch 2 times, most recently from 7bad2fb to f216852 Compare March 29, 2019 18:54
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1488312 branch 6 times, most recently from cb353a3 to e8d4956 Compare April 5, 2019 16:40
Major changes:
 - Consolidate stateful global scope and stateless global scope. i.e.
 only select one global scope randomly upon mutation.
 - No longer create animator instances on both global scopes. Instead,
 create one instance on the selected global scope and upon switching
 global scopes create a new one on the new global scope with all the
 properties transferred. For stateful animators, the state gets
 transferred as well.

Bug: 914918
Change-Id: I13837eb787dcc671492e8c5fbba6176a3bf34cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488312
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648282}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants