Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: 1.11.5 -> 1.11.6 and 1.12 -> 1.12.1 #57711

Merged
merged 2 commits into from Mar 22, 2019
Merged

Go: 1.11.5 -> 1.11.6 and 1.12 -> 1.12.1 #57711

merged 2 commits into from Mar 22, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 15, 2019 •
edited

Motivation for this change

Release notes: 1.11.6 and 1.12.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit marked this pull request as ready for review March 15, 2019 18:57
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go_1_11 go_1_12 jx pet docker

@kalbasit kalbasit changed the title [WIP] Go: 1.11.5 -> 1.11.6 and 1.12 -> 1.12.1 Go: 1.11.5 -> 1.11.6 and 1.12 -> 1.12.1 Mar 15, 2019
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go_1_12

@kalbasit
Copy link
Member Author

kalbasit commented Mar 17, 2019 •
edited

I spoke with @LnL7 with regards to the failing build, and he says that he switched on the sandbox on the Darwin builds and that’s why this PR is failing. I will attempt a fix at a later time. @LnL7 pushed a commit to this PR to fix the check issue on Darwin.

@vcunat please merge this to staging at your earliest convenience.

@kalbasit kalbasit mentioned this pull request Mar 18, 2019
Closed
10 tasks
@kalbasit kalbasit changed the base branch from master to staging March 21, 2019 00:11
@kalbasit kalbasit changed the base branch from staging to master March 21, 2019 00:12
@kalbasit
Copy link
Member Author

@vcunat there's a merge conflict on staging, I'm not comfortable merging it myself. Please help me get this PR merged. Thanks!

@kalbasit kalbasit requested a review from ttuegel as a code owner March 21, 2019 20:13
@LnL7 LnL7 changed the base branch from master to staging March 21, 2019 20:14
@LnL7
Copy link
Member

LnL7 commented Mar 21, 2019

cacert was added to build inputs on staging which adds SSL_CERT_FILE automatically making 06cda50 and the other variables unnecessary.

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go_1_11 go_1_12 jx pet docker

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go_1_11 go_1_12 jx pet docker

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go_1_12 go_1_11

@kalbasit kalbasit merged commit c465292 into NixOS:staging Mar 22, 2019
@kalbasit kalbasit deleted the nixpkgs_update-go branch March 22, 2019 17:24
vcunat pushed a commit that referenced this pull request Apr 7, 2019
@kalbasit @vcunat
Merge #57711: go: 1.11.5 -> 1.11.6
a58fe6e 
(cherry picked from commit c465292)
Fixes #58264 CVE-2019-9741
vcunat pushed a commit that referenced this pull request Apr 7, 2019
@kalbasit @vcunat
Merge #57711: go: 1.11.5 -> 1.11.6 and 1.12 -> 1.12.1
f2d7f2b 
(cherry picked from commit c465292)
Security fixes /cc #58264 and #58265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @LnL7 @GrahamcOfBorg