@fgaz What problem are you solving with this? Adding extra variants means burden in maintaining more packages.

@veprbl Thanks for the review!

What problem are you solving with this

I want to separate client and server, so people can install for example just the server part without bringing in GUI/client deps, but yeah, I got carried away and added -headless and -kis.

What about:

• keeping all the options as arguments
• adding two extra args to enable/disable the optional deps
  • or even an arg for each optional dep (enableGifSupport etc)
• just adding a -server-headless variant so hydra can build it

adding two extra args to enable/disable the optional deps

I'm not convinced there is such a big value in having knobs to fine tune all these optional dependencies. I think we usually enable all optional stuff unconditionally for maximal convenience. If someone doesn't want to build with giflib they can always use drawpile.override { giflib = null; }. You can mention what dependencies are optional in a comment, this should be more than enough for an advanced user.

just adding a -server-headless variant so hydra can build it

This sounds good. If you expect that most people would rather use either a full gui client and server or a headless server install then it greatly reduces number of options that we need to provide. We can keep -kis variant if you think you need it.

Waiting for drawpile/Drawpile#744 for kis. I'll just modify the default without adding any -kis variant if they say to enable it.

It seems like they say that they don't need it. Also you probably don't need to package any special setups unless you use them yourself.

All done. Ping @veprbl

@fgaz Thanks!