Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssb-server: 13 > 15 #57572

Closed
wants to merge 1 commit into from
Closed

ssb-server: 13 > 15 #57572

wants to merge 1 commit into from

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Mar 13, 2019

Motivation for this change

the scuttlebot was deprecated at 13.0.0, it's new name is ssb-server, which currently is at 14.1.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jacereda jacereda mentioned this pull request Mar 14, 2019
Closed
@cryptix
Copy link
Contributor Author

cryptix commented Mar 27, 2019

rebased to fix the merge conflicts.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Do you mind rebasing this again? @cryptix

@cryptix cryptix changed the title ssb-server: 13 > 14 ssb-server: 13 > 15 Aug 13, 2019
@cryptix
Copy link
Contributor Author

cryptix commented Aug 13, 2019

@mmahut done

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build ssb-server

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Looks like this has been included in fae732e?

@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

Yep

@FRidh FRidh closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cryptix @mmahut @FRidh @matthewbauer @veprbl @infinisil @GrahamcOfBorg