Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wake-lock] Adapted the rest tests to latest spec #15803

Merged
merged 3 commits into from Mar 15, 2019

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Mar 13, 2019

  • Remove wakelock-api.https.html as I believe they should be
    covered by IDL tests
  • Remove wakelock-cancel-twice.https.html, wakelockrequest-is-independent.https.html,
    wakelock-promise.https.html as those APIs had been changed, I will add
    tests for the new ones in a follow-up.

- Remove wakelock-api.https.html as I believe they should be
  covered by IDL tests
- Remove wakelock-cancel-twice.https.html, wakelockrequest-is-independent.https.html,
  wakelock-promise.https.html as those APIs had been changed, I will add
  tests for the new ones in a follow-up.
@Honry
Copy link
Contributor Author

Honry commented Mar 14, 2019

@kenchris, @marcoscaceres, would you PTAL? thanks!

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of AbortSignal throughout looks good.

@Honry
Copy link
Contributor Author

Honry commented Mar 15, 2019

Thanks @marcoscaceres, merge it as is.

@Honry Honry merged commit ea2ee73 into web-platform-tests:master Mar 15, 2019
@Honry Honry deleted the wake-lock-3 branch March 15, 2019 08:12
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
* [wake-lock] Adapted the rest tests to latest spec

- Remove wakelock-api.https.html as I believe they should be
  covered by IDL tests
- Remove wakelock-cancel-twice.https.html, wakelockrequest-is-independent.https.html,
  wakelock-promise.https.html as those APIs had been changed, I will add
  tests for the new ones in a follow-up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants