New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'unhandledrejection' in payment-request/updateWith-method-pmi-handling-manual.https.html #15861
Comments
Yes, that's definitely a bug... but not the bug. Looking into it. |
This is really odd.... it's also as if Chrome is throwing an exception on Firefox is sadly broken still so can't even test the first part. Sending a patch... but it doesn't seem to help. But at least the test runs in Safari. |
Ok, sent #15891 ... at least it fixes the |
If you figure it out, I’d be super interested to hear what is wrong. It’s likely the test, but I’m also at a loss. |
@danyao pinning seems to be some global thing, which isn't that useful for a single test bug :) |
Oops sorry I didn't realize this. Thanks @gsnedders! |
Closing, as this test no longer exists. |
The individual test cases in payment-request/updateWith-method-pmi-handling-manual.https.html seem to pass all test assertions, but still end up with a test harness error due to an
unhandledrejection
event firing.I can't figure out where the unhandled rejection comes from. All of these tests call
PaymentRequestUpdateEvent.updateWith(invalidDetails)
, whereinvalidDetails
contains an invalid payment method identifier. This causes the update to be aborted with aRangeError
and rejectsrequest.[[showPromise]]
, both are expected according to the spec. The test verifies this rejection withawait promise_rejects(t, new RangeError(), showPromise);
. What's strange is that the test report shows a pass for the test but with a harness error:It's also weird that the last test case on the page doesn't exhibit this behavior. The only difference between it and the others is that it calls
done()
right after the test method (here). I wonder if this is a race condition betweendone()
and theunhandledrejection
event handler triggering.Because of this problem, the test page has to be reloaded after each test case. I'd like to fix it, but need help figuring out where the unhandled rejection comes from.
@marcoscaceres any ideas?
The text was updated successfully, but these errors were encountered: