Fix e66cec8f86: Permit loading of industry production callback with invalid cargo type. #7364
+41
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now loads the test grf from https://github.com/OpenTTD/nml/files/2949781/firs.grf.zip |
PeterN
force-pushed
the
allow-invalid-industry-production-callback-result
branch
from
16cc29c to
836d71b
Compare
PeterN
added
the
backport requested
|
Still works after force-push update. |
PeterN
force-pushed
the
allow-invalid-industry-production-callback-result
branch
from
7aad949 to
55ad7d4
Compare
nielsmh
reviewed
Mar 10, 2019
…lid cargo type. It is only an error if the invalid result is actually used. This will be silently ignored at the moment. It is still an error if a duplicate cargo type is returned.
PeterN
force-pushed
the
allow-invalid-industry-production-callback-result
branch
from
55ad7d4 to
b91add4
Compare
nielsmh
approved these changes
Mar 15, 2019
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only an error if the invalid result is actually used. This will be silently ignored at the moment.