Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wpt test for service worker registration from signed exchange #15839

Merged
merged 1 commit into from Mar 14, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Mar 14, 2019

Bug: 939237
Change-Id: I956f1b1bc0b66f249b337b0c190c7cd5fcd96eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519951
Reviewed-by: Kunihiko Sakamoto ksakamoto@chromium.org
Commit-Queue: Tsuyoshi Horo horo@chromium.org
Cr-Commit-Position: refs/heads/master@{#640558}

Bug: 939237
Change-Id: I956f1b1bc0b66f249b337b0c190c7cd5fcd96eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519951
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640558}
@foolip
Copy link
Member Author

foolip commented Mar 14, 2019

I had to manually export this because of a conflict in lint.whitelist. git rebase was able to automatically resolve it, it was trivial.

@Hexcles
Copy link
Member

Hexcles commented Mar 14, 2019

@foolip you missed the chromium-export label so the exporter was still complaining.

@Hexcles
Copy link
Member

Hexcles commented Mar 14, 2019

Looks like legit timeout on Firefox: https://tools.taskcluster.net/groups/WOR45FE1QpGPwh88txWQ-Q/tasks/PUWFI0c3SDOe2Q5xGA3k0g/runs/0/logs/public%2Flogs%2Flive.log#L9632

Also Firefox hasn't implemented sxg anyway, so I'm force-merging it.

@Hexcles Hexcles merged commit 1b8bf0b into master Mar 14, 2019
@Hexcles Hexcles deleted the foolip/export-1519951 branch March 14, 2019 17:59
@foolip
Copy link
Member Author

foolip commented Mar 14, 2019

@Hexcles thanks for merging! Taskcluster took so long I had to go home before it finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants