Allow user agent to return payerPhone structured according to E.164. #15837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
edenchuang,
marcoscaceres,
romandev,
rsolomakhin and
zouhir
danyao
requested review from
rsolomakhin
and removed request for
domenic,
rsolomakhin,
romandev,
zouhir and
edenchuang
rsolomakhin
reviewed
Mar 14, 2019
payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html
Outdated
Show resolved
Hide resolved
rsolomakhin
approved these changes
Mar 14, 2019
|
LGTM % nit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://crbug.com/941838
Change this test to allow
PaymentResponse.payerPhoneto be format agnostic instead of enforcing International format, because the spec allows user agent to optionally adhere to E.164:https://w3c.github.io/payment-request/#addressinit-dictionary
https://en.wikipedia.org/wiki/E.164