Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with C++17 and C++20, fix with libc++ #2723

Closed
wants to merge 5 commits into from
Closed

Fix build with C++17 and C++20, fix with libc++ #2723

wants to merge 5 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 14, 2019

No description provided.

zimbatm
zimbatm approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. both last commits could be squashed with the first one

@edolstra
Copy link
Member

Thanks, rebased and applied.

@edolstra edolstra closed this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @edolstra @zimbatm