Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liberation_ttf: 2.00.4 -> 2.00.5 #57604

Closed
wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 13, 2019

Motivation for this change

https://github.com/liberationfonts/liberation-fonts/blob/2.00.5/ChangeLog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 13, 2019

hash mismatch.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 13, 2019

I was wondering-- our use of outputHash style here seems .. fragile?

Not entirely surprised the hash is different, the two main dependencies here are fontforge and fonttools and I'm on much newer fontforge and slightly newer fonttools (former is chasing git, latter I will make a PR for soon oops).

Fixing the hash is easy enough, but that doesn't seem like the right answer.
If we're fetching the fonts maybe we should just grab the prebuild files instead?

Previously: #51331 and its successor #51956

cc @worldofpeace as involved with those (along with a certain @dtzWill character... :))

@worldofpeace
Copy link
Contributor

I was wondering-- our use of outputHash style here seems .. fragile?

Not entirely surprised the hash is different, the two main dependencies here are fontforge and fonttools and I'm on much newer fontforge and slightly newer fonttools (former is chasing git, latter I will make a PR for soon oops).

Fixing the hash is easy enough, but that doesn't seem like the right answer.
If we're fetching the fonts maybe we should just grab the prebuild files instead?

Previously: #51331 and its successor #51956

cc @worldofpeace as involved with those (along with a certain @dtzWill character... :))

I feel like we should prefer a source build, but if there's limitations that we can't work around easily it's not worth it.

(good to see that certain character back with an update btw 😄 )

@7c6f434c
Copy link
Member

I think having a source build is a generally preferred situation; committing to reproducibility via outputHash is a relatively bold move, although of course if reproducibility can be ensured it is nice.

But I don't keep up with making Fontforge output reproducible.

@prusnak
Copy link
Member

prusnak commented Apr 29, 2020

Latest release is 2.1.0. Will you update the PR?

@worldofpeace
Copy link
Contributor

Let's close it since it's very out of date.

@prusnak could you open an update request issue?

@prusnak
Copy link
Member

prusnak commented Apr 29, 2020

PR in #86343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants