Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inter-ui: 3.1 -> 3.3 #57605

Merged
merged 1 commit into from Mar 13, 2019
Merged

inter-ui: 3.1 -> 3.3 #57605

merged 1 commit into from Mar 13, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 13, 2019

Motivation for this change

FWIW new name but not sure worth renaming attribute
(to 'inter' or maybe 'inter-font'?)

https://github.com/rsms/inter/releases/tag/v3.3
https://github.com/rsms/inter/releases/tag/v3.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
inter-ui: 3.1 -> 3.3
9ebbefb 
FWIW new name but not sure worth renaming attribute
(to 'inter' or maybe 'inter-font'?)

https://github.com/rsms/inter/releases/tag/v3.3
https://github.com/rsms/inter/releases/tag/v3.2
@xeji
Copy link
Contributor

xeji commented Mar 13, 2019

Don't think it's worth the hassle of renaming the attribute.

@xeji xeji merged commit 4d82af0 into NixOS:master Mar 13, 2019
@infinisil infinisil mentioned this pull request Mar 29, 2019
Closed
10 tasks
@ivan
Copy link
Member

ivan commented Mar 29, 2019

I don't think fonts should be bumped like this when the name of the font changes. It breaks existing font configuration (using "Inter UI" instead of the new "Inter"), and Emacs even fails to start up. If the last "Inter UI" was 3.2, maybe inter-ui could have been left at 3.2 and removed at some point in the future. Sorry to jump in 15 days too late.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 29, 2019
@dtzWill
Revert "inter-ui: 3.1 -> 3.3 (NixOS#57605)"
94f96bf 
Don't change font name for the `inter-ui` attribute,
breaks configs (as reported by a user on the PR).

This reverts commit 4d82af0.
@dtzWill dtzWill mentioned this pull request Mar 29, 2019
Merged
10 tasks
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Apr 5, 2019
@dtzWill
Revert "inter-ui: 3.1 -> 3.3 (NixOS#57605)"
3d3bf7d 
Don't change font name for the `inter-ui` attribute,
breaks configs (as reported by a user on the PR).

This reverts commit 4d82af0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @xeji @ivan @GrahamcOfBorg