Skip to content

parlatype: init at version 1.6-beta #57593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2019
Merged

parlatype: init at version 1.6-beta #57593

merged 5 commits into from
Mar 15, 2019
+76 −0

Conversation

melchips
Copy link
Contributor

Motivation for this change

Added package parlatype, a minimal audio player for manual speech transcription, at version v1.6-beta.

Things done

Added package, and myself to maintainers list.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@melchips
parlatype: init at version 1.6-beta

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lsix lsix
GPG key ID: 02E1542BA66FB047
Expired
Verified
Learn about vigilant mode
f490907
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 13, 2019
ryantm
ryantm requested changes Mar 15, 2019
View reviewed changes
@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

The nixpkgs policy is to package the latest stable release of a package. Can we change the version to 1.5.6 (the latest stable release) for now?

ryantm and others added 4 commits March 15, 2019 10:14
@ryantm @melchips
Update pkgs/applications/audio/parlatype/default.nix

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lsix lsix
GPG key ID: 02E1542BA66FB047
Expired
Verified
Learn about vigilant mode
eda0629 
Removing version from package name.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
@ryantm @melchips
Update pkgs/applications/audio/parlatype/default.nix
8513438 
Removing the leading 'v' on the version attribute.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
@ryantm @melchips
Update pkgs/applications/audio/parlatype/default.nix
f245241 
Using pname as github repository name.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
@ryantm @melchips
Update pkgs/applications/audio/parlatype/default.nix
01a84c1 
Using tag instead of specific commit revision.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
@melchips
Copy link
Contributor Author

Thanks @ryantm for those fixes.

The nixpkgs policy is to package the latest stable release of a package. Can we change the version to 1.5.6 (the latest stable release) for now?

Sadly, the build system has been changed between those two versions (autotools to meson).
A final release is planned for April (see https://github.com/gkarsay/parlatype/releases/tag/v1.6-beta)

What would be the best course of action ?

  • wait for the stable release in April and submit another pull request
  • submit this package to the unstable channel instead
  • try to port the current stable version

Thanks for your input ^^

@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

  • submit this package to the unstable channel instead

Merges to the master branch are what ends up in the unstable channel after they are built by Hydra.

If we already had parlatype in nixpkgs, I would say wait until April for the stable release, but since we don't have it packaged, it seems like the most value we can get out of our work would be to merge this and then do a separate PR to update to the stable version in April.

@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

@GrahamcOfBorg build parlatype

@ryantm ryantm merged commit a9bbf7b into NixOS:master Mar 15, 2019
@alexshpilkin alexshpilkin mentioned this pull request Oct 13, 2022
Merged
13 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@melchips @ryantm @GrahamcOfBorg @Janik-Haag