Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron cash update #57594

Merged
merged 2 commits into from Mar 14, 2019
Merged

Electron cash update #57594

merged 2 commits into from Mar 14, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Mar 13, 2019 •
edited

Motivation for this change

Fix failed build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre requested a review from FRidh as a code owner March 13, 2019 17:24
@nyanloutre nyanloutre force-pushed the electron-cash-update branch 2 times, most recently from 7770520 to 213bb27 Compare March 13, 2019 17:26
@nyanloutre
Copy link
Member Author

Can be backported to 19.03 to fix the build

dotlambda
dotlambda requested changes Mar 14, 2019
View reviewed changes
pkgs/applications/misc/electron-cash/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/electron-cash/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/qdarkstyle/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/qdarkstyle/default.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 14, 2019
@nyanloutre
Copy link
Member Author

@dotlambda I applied your suggestions, thanks

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.qdarkstyle python3.pkgs.qdarkstyle

@dotlambda
Copy link
Member

@GrahamcOfBorg build electron-cash

@dotlambda dotlambda merged commit aacd06e into NixOS:master Mar 14, 2019
@dotlambda
Copy link
Member

cherry picked in 3eb63d1 and 97042d8

@nyanloutre nyanloutre deleted the electron-cash-update branch March 14, 2019 11:35
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @dotlambda @samueldr @GrahamcOfBorg