Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoinarmory: fix build #57674

Merged
merged 1 commit into from Mar 15, 2019
Merged

bitcoinarmory: fix build #57674

merged 1 commit into from Mar 15, 2019

Conversation

stephengroat
Copy link
Contributor

for #56826 see https://hydra.nixos.org/build/90482597/nixlog/2

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

@GrahamcOfBorg build bitcoinarmory

@xeji xeji merged commit 7251fc2 into NixOS:master Mar 15, 2019
xeji pushed a commit that referenced this pull request Mar 15, 2019
@stephengroat stephengroat deleted the patch-2 branch March 15, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants