Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.totem: Add codecs to Nautilus extension #57619

Closed
wants to merge 1 commit into from
Closed

gnome3.totem: Add codecs to Nautilus extension #57619

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 14, 2019 •
edited

Motivation for this change

Nautilus does not depend on multimedia codecs, therefore the GST environment variables might not be present. When that is the case the multimedia properties panel provided by Totem will not be able to work. Let’s make sure the GStreamer plug-ins are loaded by hardcoding them in the extension.

Blocked by: #57027
Closes: #53631

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.totem: Add codecs to Nautilus extension
7cd7d0e 
Nautilus does not depend on multimedia codecs, therefore the GST
environment variables might not be present. When that is the case
the multimedia properties panel provided by Totem will not be able
to work. Let’s make sure the GStreamer plug-ins are loaded by hardcoding
them in the extension.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 14, 2019
@jtojnar jtojnar mentioned this pull request Mar 16, 2019
Merged
28 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 19, 2019

In GNOME 3.32, this is no longer part of Totem.

@jtojnar jtojnar closed this Mar 19, 2019
@jtojnar jtojnar deleted the totem-nautilus-codecs branch March 19, 2019 14:14
@jtojnar jtojnar mentioned this pull request Dec 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg