Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-all-the-icons-fonts: 3.1.1 -> 3.2.0 #57644

Merged
merged 1 commit into from Mar 17, 2019
Merged

emacs-all-the-icons-fonts: 3.1.1 -> 3.2.0 #57644

merged 1 commit into from Mar 17, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 14, 2019

Motivation for this change

Update to version 3.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

xeji
xeji suggested changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix hash mismatches

@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

Now only the version number is updated but the sha256 remains unchanged. Is this correct?

@romildo
Copy link
Contributor Author

romildo commented Mar 17, 2019

Now only the version number is updated but the sha256 remains unchanged. Is this correct?

It happens that only the fonts are installed in this derivation, and it looks like they have not been changed from the prior version. The emacs part is installed by other means.

I would update only to keep the version number up to date.

@xeji
Copy link
Contributor

xeji commented Mar 17, 2019

Fine, let's do that.

@xeji xeji merged commit 711a57d into NixOS:master Mar 17, 2019
@romildo romildo deleted the upd.emacs-all-the-icons branch March 18, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @xeji @GrahamcOfBorg