Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: 1.2.4 -> 1.2.5 #57646

Merged
merged 1 commit into from Mar 14, 2019
Merged

containerd: 1.2.4 -> 1.2.5 #57646

merged 1 commit into from Mar 14, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 14, 2019 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to latest minor release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
containerd: 1.2.4 -> 1.2.5
115dde6 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@xeji
Copy link
Contributor

xeji commented Mar 14, 2019

nix-review shows no issues. docker test passes locally.

@xeji xeji merged commit ef1cdfb into NixOS:master Mar 14, 2019
@vdemeester vdemeester deleted the update-containerd branch March 14, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @xeji @GrahamcOfBorg