Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2fsprogs: use buildPackages.perl to avoid cycle in llvm-based stdenv #57645

Merged
merged 1 commit into from Mar 15, 2019
Merged

e2fsprogs: use buildPackages.perl to avoid cycle in llvm-based stdenv #57645

merged 1 commit into from Mar 15, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 14, 2019

Motivation for this change

Fixes eval regression for llvm-based cross-stdenv's and possibly others.
Introduced in #57229.

Happily in the non-cross case this doesn't change the hash! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from 7c6f434c March 14, 2019 21:30
@7c6f434c
Copy link
Member

For the record: e2fsprogs → libarchive → cmake

@dtzWill dtzWill merged commit 85966e6 into NixOS:staging Mar 15, 2019
@dtzWill dtzWill deleted the fix/e2fsprogs-cross-llvm-bootstrap branch March 15, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @7c6f434c @GrahamcOfBorg