Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipxe: 20180220 -> 20190310 #57582

Merged
merged 1 commit into from Mar 15, 2019
Merged

ipxe: 20180220 -> 20190310 #57582

merged 1 commit into from Mar 15, 2019

Conversation

adamtulinius
Copy link
Member

Motivation for this change

This fixes #57581 by updating iPXE to a newer version, which incorporates the patch from https://bugzilla.opensuse.org/show_bug.cgi?id=1105510, which has been upstreamed.

Please cherry-pick to 19.03

Things done

Tested by making a server boot over the network with ipxe

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adamtulinius
Copy link
Member Author

adamtulinius commented Mar 13, 2019 •
edited

The reason this doesn't fail on hydra, is that the bug is only related to the EFI targets of ipxe. We could change the pkg to build everything, which would cause longer build times, but also catch potential errors like these in the future.

Despite not actually failing, it's probably still related to #56826 :P

@adamtulinius adamtulinius mentioned this pull request Mar 13, 2019
Closed
@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

@GrahamcOfBorg build ipxe

@xeji xeji merged commit d835df0 into NixOS:master Mar 15, 2019
xeji pushed a commit that referenced this pull request Mar 15, 2019
@adamtulinius @xeji
ipxe: 20180220 -> 20190310 (#57582)
c1f0b9b 
(cherry picked from commit d835df0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipxe build failures on 19.03
3 participants
@adamtulinius @xeji @GrahamcOfBorg