[css-properties-values-api] Compute <length> values to px. #15811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, the computed value of <length> registered properties
is the absolute value expressed in pixels. Currently, we are only behaving
correctly if the value is a calc() or if the CSSPrimitiveValue contains a
relative unit (e.g. em). This means that values like '1in' would not be
expressed in pixels.
As of this CL, we absolutize any <length> which isn't already a simple
(non-calc) px value.
R=futhark@chromium.org
Bug: 641877
Change-Id: Idec079671a094952e122847fc5ebd4b0cb609674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520586
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640922}