Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lcov: 1.13 -> 1.14 #57684

Merged
merged 1 commit into from
Mar 17, 2019
Merged

lcov: 1.13 -> 1.14 #57684

merged 1 commit into from
Mar 17, 2019
+3 −3

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Get reproducible coverage reports (SOURCE_DATE_EPOCH support).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested a review from dezgeg March 15, 2019 09:20
@bjornfor
lcov: 1.13 -> 1.14
f458baf 
No need to set BIN_DIR, MAN_DIR anymore, but have to set LCOV_PERL_PATH
now.
@bjornfor bjornfor merged commit 83d5629 into NixOS:master Mar 17, 2019
@bjornfor bjornfor deleted the lcov branch March 17, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @GrahamcOfBorg