Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git manifest generation to actually find local changes #15862

Merged
merged 2 commits into from Mar 15, 2019

Conversation

gsnedders
Copy link
Member

Previously we'd never consider anything changed, ever, because we took the whole short-format line to be the rel_path (it isn't). This has been broken since MANIFESTv4 landed in 2016(!).

@gsnedders
Copy link
Member Author

I broke this by relying on git/git@e8b2dc2 and not checking what version of git it required (2.21.0). Whoops.

@gsnedders gsnedders merged commit 554d594 into web-platform-tests:master Mar 15, 2019
@gsnedders gsnedders deleted the _local_changes_fix branch March 15, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants