Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.arbtt: 0.10.1 -> 2019-01-27, dontCheck #57585

Closed
wants to merge 1 commit into from
Closed

haskellPackages.arbtt: 0.10.1 -> 2019-01-27, dontCheck #57585

wants to merge 1 commit into from

Conversation

erictapen
Copy link
Member

Motivation for this change

arbtt was broken for quite a while.

Things done

Recently fixes for the build failure were published to master, so I just bumped the source to current master.

Also needed to disable tests to run, as they seem to be broken in an easy to fix way.

I tested execution of the binaries and they are able to parse my logs.

This needs to be backported to release-18.09.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
haskellPackages.arbtt: 0.10.1 -> 2019-01-27, dontCheck
862c0d2 
arbtt was broken for quite a while. Recently fixes for the build failure
were published to master, so I just bumped the source to current master.

Also needed to disable tests to run, as they seem to be broken in an
easy to fix way.

I tested execution of the binaries and they are able to parse my logs.
@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.arbtt

@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.arbtt

peti
peti requested changes Mar 16, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

pkgs/development/haskell-modules/configuration-common.nix
@@ -1154,7 +1154,15 @@ self: super: {

xmonad-extras = doJailbreak super.xmonad-extras;

arbtt = doJailbreak super.arbtt;
arbtt = overrideSrc (dontCheck super.arbtt) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea. That override will hide all future updates arbtt receives. Unless there is some kind of plan how to prevent that from happening, I'd rather not commit a change like that unless there's very good reason to.

Generally speaking, I'd very much prefer to lobby @nomeata to simply release a new Hackage version.

@nomeata
Copy link
Contributor

nomeata commented Mar 16, 2019

Generally speaking, I'd very much prefer to lobby @nomeata to simply release a new Hackage version.

You wish is my command. Uploaded as 0.10.2.

@peti
Copy link
Member

peti commented Mar 17, 2019

You wish is my command. Uploaded as 0.10.2.

Thank you very much. :-) We got the update in e98e4d2. So the only issue that's left is the failing test suite:


Running 1 test suites...
Test suite test: RUNNING...
Tests
  Golden tests
    dump small:                                                         FAIL
      arbtt-dump: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    import small:                                                       FAIL
      arbtt-import: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    dump small JSON:                                                    FAIL
      arbtt-dump: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    import small JSON:                                                  FAIL
      arbtt-import: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    import small JSON (list):                                           FAIL
      arbtt-import: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    recover small:                                                      FAIL
      arbtt-recover: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    stats small:                                                        FAIL
      arbtt-stats: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    stats small csv:                                                    FAIL
      arbtt-stats: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    stats small unicode:                                                FAIL
      arbtt-stats: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    stats gap handling:                                                 FAIL
      arbtt-stats: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
    condition binding stats:                                            FAIL
      arbtt-stats: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
  Regression tests
    Issue #4:                                                           OK
    Issue #5:                                                           OK
    Issue #14:                                                          OK
  Parser tests
    Parse condition bindings:                                           OK
    Trying to bind reserved identifiers:                                OK
    Reference bound condition identifiers:                              OK
    Parse condition binding usage in rule:                              OK
    Reference unbound condition identifier:                             OK
    Variables are only accessible within the condition assignment body: OK

11 out of 20 tests failed (0.00s)
Test suite test: FAIL

@peti peti closed this in 7c04e3e Mar 17, 2019
@erictapen
Copy link
Member Author

@peti Thanks for the fix.

arbtt is still brocken on release-19.03. Do I see it right, that e98e4d2 cannot be backported to release-19.03? If yes, I'd try to submit a new PR with the necessary bits but without the problem of hidden future updates you described in #57585 (comment).

@peti
Copy link
Member

peti commented Mar 18, 2019

Do I see it right, that e98e4d2 cannot be backported to release-19.03?

We cannot port the whole commit, but it's possible to back-port the part of it that updates arbtt.

@erictapen erictapen mentioned this pull request Mar 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erictapen @nomeata @peti @GrahamcOfBorg