Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix NeedsLayout crashes, part 3 #15845

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 14, 2019

Location on OOF with inline container, and anonymous
containing block should be wrt inline container.

Added a test. It fails in Legacy, and crashes in NG.
NG crash will be corrected in further CL.

Bug: 935805
Change-Id: I9f0490f79980b997215477d44735c6b899b84520

Reviewed-on: https://chromium-review.googlesource.com/1524863
WPT-Export-Revision: 56c62aa686b9df26c8b6179227f65e376aa89989

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Location on OOF with inline container, and anonymous
containing block should be wrt inline container.

Added a test. It fails in Legacy, and crashes in NG.
NG crash will be corrected in further CL.

Bug: 935805
Change-Id: I9f0490f79980b997215477d44735c6b899b84520
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [LayoutNG] Part 3 of fix for AssertLaidOut [LayoutNG] Fix NeedsLayout crashes, part 3 Mar 14, 2019
@KyleJu
Copy link
Contributor

KyleJu commented May 10, 2019

Close this PR because the Chromium CL has been abandoned.

@KyleJu KyleJu closed this May 10, 2019
@KyleJu KyleJu deleted the chromium-export-cl-1524863 branch May 10, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants