Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kfind: init at 18.12.1 #57657

Merged
merged 1 commit into from
Mar 15, 2019
Merged

kfind: init at 18.12.1 #57657

merged 1 commit into from
Mar 15, 2019
+18 −0

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Mar 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@iblech iblech requested a review from ttuegel as a code owner March 14, 2019 18:52
@GrahamcOfBorg GrahamcOfBorg added 6.topic: qt/kde 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 14, 2019
@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

@GrahamcOfBorg build kdeApplications.kfind

@ryantm ryantm merged commit 943239b into NixOS:master Mar 15, 2019
@iblech
Copy link
Contributor Author

iblech commented Mar 15, 2019

Thank you @ryantm for the quick review and merge. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblech @ryantm @GrahamcOfBorg