Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Allow configuration of extra initializers #57578

Merged
merged 1 commit into from
Mar 26, 2019
Merged

nixos/gitlab: Allow configuration of extra initializers #57578

merged 1 commit into from
Mar 26, 2019
+23 −0

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 13, 2019

This adds a configuration option allowing the addition of additional
initializers in config/extra-gitlab.rb.

Motivation for this change

Some GitLab configuration (e.g. mail configuration) is only configurable via initializers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@bgamari bgamari requested a review from infinisil as a code owner March 13, 2019 11:58
@bgamari
Copy link
Contributor Author

bgamari commented Mar 13, 2019

CC @fpletz @globin

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 13, 2019
@bgamari
Copy link
Contributor Author

bgamari commented Mar 20, 2019

Ping.

@flokli
Copy link
Contributor

flokli commented Mar 22, 2019

@bgamari can you point to some gitlab docs / add an example to the configuration option?

@flokli flokli mentioned this pull request Mar 25, 2019
Merged
10 tasks
@bgamari
nixos/gitlab: Allow configuration of extra initializers
f2bdc91 
This adds a configuration option allowing the addition of additional
initializers in config/extra-gitlab.rb.
@bgamari bgamari force-pushed the gitlab-extra-initializers branch from 69a084f to f2bdc91 Compare March 25, 2019 19:18
@bgamari
Copy link
Contributor Author

bgamari commented Mar 25, 2019

Done. I'm afraid there isn't any particular documentation to point to. This option is really an escape-hatch to allow configuration that isn't otherwise available using the module's options. I did, however, add an example showing one usage.

@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

Fair enough :-)

@flokli flokli merged commit 476760b into NixOS:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @flokli @GrahamcOfBorg