Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odyssey: init at 2019-03-12 #57576

Merged
merged 1 commit into from Mar 17, 2019
Merged

odyssey: init at 2019-03-12 #57576

merged 1 commit into from Mar 17, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 13, 2019

Motivation for this change

Add https://github.com/yandex/odyssey

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Mar 15, 2019
View reviewed changes
pkgs/tools/misc/odyssey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/odyssey/default.nix Outdated Show resolved Hide resolved
ryantm
ryantm requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it tries to build for the aarch64 architecture there is an error:

#  error unsupported architecture

Can you please look into the error, or restrict the meta.platforms to not include aarch64?

@marsam
Copy link
Contributor Author

marsam commented Mar 16, 2019

Fixed

@ryantm ryantm merged commit 5d5c24b into NixOS:master Mar 17, 2019
@marsam marsam deleted the init-odyssey branch March 17, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @ryantm @GrahamcOfBorg