nixos/matrix: write manual section #57699
Conversation
|
@Ekleog this is yet missing a changelog entry / edit of the matrix-synapse 1.0 changelog warning you mentioned in #55320 (comment), depending on whether this can still go in 19.03. |
There was a problem hiding this comment.
@florianjacob As this is a manual change only, I'm pretty sure it'll be OK to backport, so feel free to add a link to the 19.03 changelog :) I'll merge once the link is added and @pacien 's comments are addressed, thanks a lot!
| <programlisting> | ||
| let | ||
| fqdn = let | ||
| join = hostName: domain: hostName + optionalString (domain != null) ".${domain}"; |
There was a problem hiding this comment.
Potentially personal opinion ahead: I feel that this let should be after the line break. Feel free to ignore, though, we still don't have any kind of style guide for the time being.
There was a problem hiding this comment.
You mean like this?
let
fqdn =
let
join = hostName: domain: hostName + optionalString (domain != null) ".${domain}";
in join config.networking.hostName config.networking.domain;
in {
…
};Changed to this style now, the other two bindings as well.
I always struggle to format let bindings. :/ Any good example would be appreciated, as almost any let binding you find in nixpkgs is formatted differently… Can't wait for an actual style guide.
There was a problem hiding this comment.
Looks great this way, thanks! Totally agree we definitely need a style guide; currently the most frequent formattings I see are these, I think (but I'm likely biased by my own personal preferences):
{
a = let foo = bar; in baz;
b =
let foo = bar;
in baz;
c =
let
foo = bar;
in baz;
d =
let
foo = bar;
in
baz;
e =
let
foo = bar;
in
baz; # mostly used to stay at column 0
}There was a problem hiding this comment.
Those styles look very reasonable, thank you. 👍
about self-hosting a matrix client and server
florianjacob
force-pushed
the
matrix-doc
branch
from
008a077
to
ef52869
Compare
|
Thanks to all for their feedback and review, |
|
@florianjacob Thank you! Merged and backported as 4e8ace1. If someone has further issues with this, it can be fixed as an additional PR I think :) |
Motivation for this change
This was developed as part of
#55320 (comment)
with the initial intention to show users how to set up a synapse homeserver with a valid certificate, in light of the upcoming 1.0 release.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)