Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.python-engineio: 3.0.0 -> 3.4.3 #57635

Merged
merged 2 commits into from Mar 14, 2019
Merged

python3.pkgs.python-engineio: 3.0.0 -> 3.4.3 #57635

merged 2 commits into from Mar 14, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 14, 2019 •
edited

fixes build of python-socketio

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
python3.pkgs.python-engineio: 3.0.0 -> 3.4.3
f94dc01 
fixes build of python-socketio
@Mic92 Mic92 requested a review from FRidh as a code owner March 14, 2019 11:15
@Mic92
Copy link
Member Author

Mic92 commented Mar 14, 2019 

@GrahamcOfBorg build python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio gdbgui

@Mic92
python3.pkgs.engineio: limit to linux
42bc961 
probably has never build on macOS.
@Mic92
Copy link
Member Author

Mic92 commented Mar 14, 2019 

@GrahamcOfBorg build python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio gdbgui

1 similar comment
@Mic92
Copy link
Member Author

Mic92 commented Mar 14, 2019 

@GrahamcOfBorg build python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio gdbgui

@Mic92 Mic92 merged commit 4d2fe32 into NixOS:master Mar 14, 2019
@Mic92 Mic92 deleted the engineio branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @dotlambda @GrahamcOfBorg