Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/wake-lock.idl #15853

Merged

Conversation

autofoolip
Copy link
Contributor

@autofoolip autofoolip commented Mar 15, 2019

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Note: This file was recently manually updated in commit 8ab29ab.
This commit may revert some of those changes.

Source: https://github.com/tidoust/reffy-reports/blob/e0218fe/whatwg/idl/wake-lock.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/506822321

@Honry
Copy link
Contributor

Honry commented Mar 15, 2019

@foolip, looks like the bot is monitoring the CR version of the spec, while there's big change of IDL in ED version.

@foolip
Copy link
Member

foolip commented Mar 15, 2019

@Honry are you sure that's what's going wrong? In header says https://w3c.github.io/wake-lock/, could it instead be that it's not updating correctly? @dontcallmedom or @tidoust might be able to help to debug this.

In the meantime, should this PR be merged?

Note: This file was recently manually updated in commit 8ab29ab.
      This commit may revert some of those changes.

Source: https://github.com/tidoust/reffy-reports/blob/e0218fe/whatwg/idl/wake-lock.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/506822321
@tidoust
Copy link
Contributor

tidoust commented Mar 15, 2019

@Honry @foolip This PR seems wrong and should be ignored.

I'm afraid that, following an apparently innocent update end of January, Reffy completely failed to send the right Authentication header with W3C API requests, meaning it could not retrieve the URL of many Editor's Drafts as a result. That should now be fixed. I updated the IDL files manually in reffy-reports. Hopefully, the crawls will now resume without incident.

@foolip
Copy link
Member

foolip commented Mar 15, 2019

@tidoust I see a bunch of new PRs today, so whatever you did seems to have had an effect :)

@foolip
Copy link
Member

foolip commented Mar 15, 2019

This branch was also updated, the change is much smaller now.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small whitespace change only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants