Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a8ab130ffc61
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3f864c02506d
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 15, 2019

  1. python.pkgs.pysrt: use buildPythonPackage and checkInputs

    (cherry picked from commit acad553)
    Robert Schütz committed Mar 15, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    zimbatm Jonas Chevalier
    Copy the full SHA
    6e9a5bf View commit details
  2. python.pkgs.subliminal: improve expression

    (cherry picked from commit fa1ada0)
    Robert Schütz committed Mar 15, 2019
    Copy the full SHA
    ce9d30c View commit details
  3. python.pkgs.restructuredtext_lint: does not support Python 3.7 yet

    (cherry picked from commit 739cf7d)
    Robert Schütz committed Mar 15, 2019
    Copy the full SHA
    3f864c0 View commit details
6 changes: 3 additions & 3 deletions pkgs/development/python-modules/pysrt/default.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{ stdenv
, buildPythonApplication
, buildPythonPackage
, fetchFromGitHub
, chardet
, nose
}:

buildPythonApplication rec {
buildPythonPackage rec {
pname = "pysrt";
version = "1.1.1";

@@ -16,7 +16,7 @@ buildPythonApplication rec {
sha256 = "0rwjaf26885vxhxnas5d8zwasvj7x88y4y2pdivjd4vdcpqrqdjn";
};

buildInputs = [ nose ];
checkInputs = [ nose ];
checkPhase = ''
nosetests -v
'';
Original file line number Diff line number Diff line change
@@ -1,33 +1,34 @@
{ lib
, buildPythonPackage
, fetchPypi
, isPy37
, docutils
, nose
, stdenv
, flake8
, pyyaml
, testtools
}:

buildPythonPackage rec {
pname = "restructuredtext_lint";
version = "1.2.2";

# https://github.com/twolfson/restructuredtext-lint/pull/47
disabled = isPy37;

src = fetchPypi {
inherit pname version;
sha256 = "82880a8de8a41bfc84f533744091b1ead8e2ab9ad6c0a3f60f4750ef6c802350";
};

checkInputs = [ nose flake8 pyyaml testtools ];
checkInputs = [ nose testtools ];
propagatedBuildInputs = [ docutils ];

checkPhase = ''
${stdenv.shell} test.sh
nosetests --nocapture
'';

meta = {
description = "reStructuredText linter";
homepage = https://github.com/twolfson/restructuredtext-lint;
license = lib.licenses.unlicense;
};
}
}
32 changes: 24 additions & 8 deletions pkgs/development/python-modules/subliminal/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ stdenv
{ lib
, fetchPypi
, buildPythonApplication
, buildPythonPackage
, isPy3k
, guessit
, babelfish
, enzyme
@@ -16,9 +17,16 @@
, rarfile
, pytz
, futures
, sympy
, vcrpy
, pytest
, pytestpep8
, pytest-flakes
, pytestcov
, pytestrunner
}:

buildPythonApplication rec {
buildPythonPackage rec {
pname = "subliminal";
version = "2.0.5";

@@ -27,13 +35,21 @@ buildPythonApplication rec {
sha256 = "1dzv5csjcwgz69aimarx2c6606ckm2gbn4x2mzydcqnyai7sayhl";
};

# Too many test dependencies
propagatedBuildInputs = [
guessit babelfish enzyme beautifulsoup4 requests
click dogpile_cache stevedore chardet pysrt six
appdirs rarfile pytz
] ++ lib.optional (!isPy3k) futures;

checkInputs = [
sympy vcrpy pytest pytestpep8 pytest-flakes
pytestcov pytestrunner
];

# https://github.com/Diaoul/subliminal/pull/963
doCheck = false;
propagatedBuildInputs = [ guessit babelfish enzyme beautifulsoup4 requests
click dogpile_cache stevedore chardet pysrt six
appdirs rarfile pytz futures ];

meta = with stdenv.lib; {
meta = with lib; {
homepage = https://github.com/Diaoul/subliminal;
description = "Python library to search and download subtitles";
license = licenses.mit;