Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pyyaml: 3.13 -> 5.1 #57688

Merged
merged 11 commits into from Apr 10, 2019
Merged

python.pkgs.pyyaml: 3.13 -> 5.1 #57688

merged 11 commits into from Apr 10, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 15, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner March 15, 2019 10:12
@dotlambda
Copy link
Member Author

There seem to be quite a lot of packages/applications pinning PyYAML to specific versions. Marking as WIP until that's improved.

@dotlambda
Copy link
Member Author

dotlambda commented Apr 3, 2019 •
edited

Incomplete Probably complete list of packages that now fail:

Maybe @garbas can create an upstream report for jenkinks-job-builder?

cc @teto @dtzWill regarding papis

Robert Schütz added 2 commits April 3, 2019 16:46
@dotlambda dotlambda mentioned this pull request Apr 4, 2019
Merged
@ckauhaus ckauhaus mentioned this pull request Apr 8, 2019
Merged
10 tasks
@dotlambda dotlambda changed the base branch from master to staging April 9, 2019 08:33
@dotlambda
Copy link
Member Author

I'll merge in a day unless someone objects.

@dotlambda dotlambda merged commit 2d29d97 into NixOS:staging Apr 10, 2019
@dotlambda dotlambda deleted the pyyaml-5.1 branch April 10, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @gebner @infinisil @GrahamcOfBorg