New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include date of Firefox Nightly in wpt_report.json #13052
Comments
Yeah, mozversion can get it from the application.ini file, assuming we know the path to the actual firefox binary (which we do in our setup, but don't in general e.g. if |
@Hexcles, I realize there might be an existing and somewhat serious problem here. If the results receiver uses the version to reject cases where the different chunks got different versions of the browsers, it's possible we have already accepted runs that are for a mix of browser version. WDYT, what's the priority of fixing this? |
Sorry I don't quite get what you meant. All (and only) chunks belonging to the same task arrive in a single request to results receiver. |
There is a race condition though; since all the tasks download the latest Firefox nightly, if there happens to be a new release between the first and last tasks starting, they won't all get the same version. In the long term we should fix this with a taskgraph that picks a nightly build and uses that version for all child tasks. |
Yep, that's the problem I meant. |
Ping from your friendly neighbourhood ecosystem infra rotation If this is |
@jgraham do you reckon this is an easy fix? |
I think "get the date into the file" is an easy fix and "get the tasks to all use the same version" is harder. |
This issue is just about "get the date into the file", then we can start least know when we're getting a mix of browser versions. |
IIRC, web-platform-tests/wpt.fyi#1068 covered being more lenient with inconsistent version (build). |
With |
The Firefox Nightly version will be something like "64.0a1" but that doesn't change for each build. In the UI the date is included.
@jgraham, is there any way we could get this information?
The text was updated successfully, but these errors were encountered: