Skip to content

linssid: fixing the build #57686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

linssid: fixing the build #57686

merged 1 commit into from
Mar 15, 2019
+9 −5

Conversation

pschuprikov
Copy link
Contributor

Motivation for this change #56826
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@pschuprikov
linssid: fix build
2d47489 
  * tell qmake about QWT, so it does not create a header target
  * set QT_PLUGIN_PATH
  * set PATH so that necessary tools are available
@GrahamcOfBorg GrahamcOfBorg requested a review from bjornfor March 15, 2019 09:58
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 15, 2019
@xeji xeji merged commit 926ec7d into NixOS:release-19.03 Mar 15, 2019
@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

picked to master (where it was also broken) in cc93879

pull bot pushed a commit to evanjs/nixpkgs that referenced this pull request Mar 15, 2019
@pschuprikov @xeji
linssid: fix build (NixOS#57686)
cc93879 
* tell qmake about QWT, so it does not create a header target
  * set QT_PLUGIN_PATH
  * set PATH so that necessary tools are available

(cherry picked from commit 926ec7d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pschuprikov @xeji @bjornfor @GrahamcOfBorg