WIP Add basic 'text-anchor' tests. #15118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
ewilligers,
heycam,
nikosandronikos and
svgeesus
Red is typically seen as an error condition in tests, so I suggest making this visual reference a different color. Why do you say the expected rendering part is "temporary"? Should the tests be merged with that part included, or excluded? |
|
The working group needs to discuss these tests... the red is to make it easier for discussion. After the WG has approved the tests, I'll remove the red. |
|
So, should we merge them to aid discussion, and then remove the temporary stuff in a separate pull request? |
svgeesus
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic SVG 'text-anchor' tests.
001 LTR Latin
002 Vertical Latin
003 RTL Arabic
102 Vertical Kanji
201 LTR Latin 'tspan'
202 Vertical Latin 'tspan'
203 RTL Arabic 'tspan'
Temporarily, tests include the expected rendering in red below the test along with a red circle to indicate anchor point. Due to how the reference is created, there may be a pixel or so difference in rendering on one or two tests.
Firefox 64 passes all tests except small errors when 'text-anchor is 'mid' on a 'tspan'. (both Firefox and Chrome appear to incorrectly include a space following the tspan in calculating the tspan position).
Chrome 71 passes all except 002, 202, 203.
Inkscape passes all except those using 'tspan'.