Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyrr: 0.10.1 -> 0.10.2 #57661

Merged
merged 1 commit into from Mar 14, 2019
Merged

pythonPackages.pyrr: 0.10.1 -> 0.10.2 #57661

merged 1 commit into from Mar 14, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Tests are missing from the Pypi source distribution of pyrr 0.10.1. Therefore building that version is failing with this error:

======================================================================
ERROR: tests (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: tests
Traceback (most recent call last):
  File "/nix/store/lwwk80ls3sb1dfljfsrrx6wlkjkd8imn-python3-3.6.8/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
ModuleNotFoundError: No module named 'tests'

pyrr version 0.10.2 has the tests packages in the source distribution, and the Nix build is thus working again, with tests.

This should also be backported to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0deaddict c0deaddict requested a review from FRidh as a code owner March 14, 2019 20:11
@xeji
Copy link
Contributor

xeji commented Mar 14, 2019

@GrahamcOfBorg build python37Packages.pyrr python27Packages.pyrr

@xeji
Copy link
Contributor

xeji commented Mar 14, 2019

cc #56826

@xeji xeji merged commit 2c4e220 into NixOS:master Mar 14, 2019
xeji pushed a commit that referenced this pull request Mar 14, 2019
@c0deaddict @xeji
pythonPackages.pyrr: 0.10.1 -> 0.10.2 (#57661)
8a124a3 
(cherry picked from commit 2c4e220)
@c0deaddict c0deaddict mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @xeji @GrahamcOfBorg