Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csound-manual by using newer git revision #57663

Merged
merged 2 commits into from Mar 24, 2019

Conversation

hlolli
Copy link
Member

@hlolli hlolli commented Mar 14, 2019

Motivation for this change

With tag 6.12.0 this error is produced

Traceback (most recent call last):
  File "csd2docbook.py", line 373, in <module>
    CsoundScoreLexer.tokens['root'][3] = (stateTuple[0], Token.Name.Builtin, stateTuple[2])
IndexError: tuple index out of range
make[1]: *** [Makefile:700: examples-xml/stamp] Error 1

This only started to happen recently after I updated my channels.

Things done

So tried the master branch of the manual, and it works, no idea what was done from the tagging to today. So I'm worried if I'm not versioning this right, if I should use the revision as version number, or it's ok to keep it like this, there hasn't been any new release of the csound manual.

  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 14, 2019

relevant for 19.03, #56826
@GrahamcOfBorg build csound-manual

@veprbl
Copy link
Member

veprbl commented Mar 24, 2019

@GrahamcOfBorg build csound-manual

@veprbl veprbl merged commit 990eaa3 into NixOS:master Mar 24, 2019
veprbl pushed a commit that referenced this pull request Mar 24, 2019
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants