Skip to content

netbeans: 8.2 -> 10.0 #57691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

netbeans: 8.2 -> 10.0 #57691

merged 1 commit into from
Mar 15, 2019
+27 −10

Conversation

rszibele
Copy link
Contributor

Motivation for this change

Latest upstream version is 10.0 with JDK 11 support. The created .desktop file also didn't have any icon associated with it and meta information needed to be amended (license, homepage).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@rszibele
netbeans: 8.2 -> 10.0
3f82b34 
Also added icon support for the desktop file and updated meta information.
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 15, 2019
@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

@GrahamcOfBorg build netbeans

@ryantm ryantm merged commit dc80bf5 into NixOS:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

@svanderburg svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rszibele @ryantm @GrahamcOfBorg