xscreensaver: Enable perl modules needed for RSS image fetch #57629
Conversation
To validate that it works, just execute, e.g.:
```
$ xscreensaver-getimage-file \
https://www.nasa.gov/rss/dyn/lg_image_of_the_day.rss
```
|
A backport to previous releases needs slight adjustment. Here is 18.09: https://github.com/booxter/nixpkgs/tree/release-18.09-xscreensaver-getimage-rss |
|
Thanks for the fix! Does 19.03 backport require any changes? Re: 18.09 — could you please open a separate PR for these changes and mention me there? In general, we try to prefix the commit message with the package name. |
7c6f434c
changed the title
|
@7c6f434c I honestly haven't checked 19.03 since I run 18.09 on my machine. The only potential change in backport I needed was to add explicit |
|
19.03 isn't even released yet, indeed — and the process of trying is probably the same as for Backport process: rather informal, people see changes that seem safe and fix bugs, and port them to release branches. When a blind cherry-picking is likely to work, mentioning the idea of backporting directly is sometimes enough. In general, it is a completely normal practice to open PRs against |
|
And what I probably should have said — it is not like you should have found some information on backporting, it is indeed not fully documented, and attempts to formalise the workflow have not fully succeeded. If you continue to contribute to Nix* (and I hope you will), you will unfortunately see some cases where a definitive guide on something cannot exist because a full agreement on detailed enough policy has never been reached. (And of course please do not take my question about 19.03 as a criticism that you haven't tried it — that's all OK and normal) |
(cherry picked from commit 4730466)
|
9388fc9 release-19.03 |
|
@7c6f434c thanks for the solid answer. :) I know how hard it is to formalize procedures, I've been on stable release team of OpenStack for a while. I've noticed you merged the fix into I will follow up with a |
xscreensaver: Enable perl modules needed for RSS image fetch (#57629)
|
It might be a bit more annoying with Nixpkgs — we also have a vaguer set of goals so the tradeoffs are hard to even enumerate from time to time… Committers currently have direct push access to all Nixpkgs branches (force-push is blocked on all branches anyone cares about). It is OK to merge PRs via manual cherry-picking or merging and pushing. It is OK to volunteer to do a backport via direct cherry-pick+push. It is expected that committers create PRs for large change; there is no real consensus on small fixes, so many committers push these directly. Maybe some day improved tooling will change all this. We also have a problem of taking too long to review some PRs (sometimes for random reasons), and the number of open PRs slowly creeps up. There are some people who do great work fighting this; last few times I tried, I burned out on that task. For 18.09 you said you had already tested a slightly different change, so I waited to merge the different PR as it was less effort for me — thanks for the backport PR. |
To validate that it works, just execute, e.g.: