Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.distro: fix build #57634

Closed
wants to merge 1 commit into from
Closed

pythonPackages.distro: fix build #57634

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner March 14, 2019 10:40
@dotlambda
Copy link
Member

Did someone try reporting these failures upstream? To me, they seem to suggest the package is outright broken.

@marsam
Copy link
Contributor Author

marsam commented Mar 14, 2019

Curiously their tests are passing on travis-ci https://travis-ci.org/nir0s/distro.
I initially tried to check about why they are failing on nix with no luck. I'm going to continue investigating later, otherwise I'm going to report it upstream.

@marsam
Copy link
Contributor Author

marsam commented Mar 16, 2019

Closing because 871cd75 already landed in master

@marsam marsam closed this Mar 16, 2019
@marsam marsam deleted the fix-pythonpackages-distro-build branch March 16, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dotlambda @GrahamcOfBorg