[WebXR] Resolve required/optional features per the spec #18512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757183
branch
2 times, most recently
from
3c0ce42
to
82e17c6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757183
branch
from
82e17c6
to
9bd93ec
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757183
branch
6 times, most recently
from
5c4ac43
to
9ba70a7
Compare
This adds support to resolve required/optional features against device capabilities as well as sets up the plumbing for appropriately tailored consent. A WPT test for lack of device support was also added, which required updating the tests. Bug: 991605 Change-Id: Ibce6924492311544fd75ca36ed79aa855c943aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757183 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jacob DeWitt <jacde@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689605}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757183
branch
from
9ba70a7
to
472f57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to resolve required/optional features against device
capabilities as well as sets up the plumbing for appropriately tailored
consent.
A WPT test for lack of device support was also added, which required
updating the tests.
Bug: 991605
Change-Id: Ibce6924492311544fd75ca36ed79aa855c943aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757183
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689605}