Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.36.0 -> 1.37.0 #66714

Closed
wants to merge 1 commit into from
Closed

rustc: 1.36.0 -> 1.37.0 #66714

wants to merge 1 commit into from

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Aug 16, 2019 •
edited

Motivation for this change

https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: rust label Aug 16, 2019
@basvandijk
Copy link
Member Author

@GrahamcOfBorg build rustc

@basvandijk basvandijk marked this pull request as ready for review August 16, 2019 12:30
@edolstra
Copy link
Member

Closing for #66714.

@edolstra edolstra closed this Aug 16, 2019
@bkchr
Copy link
Contributor

bkchr commented Aug 23, 2019

Why was this closed?

@bkchr bkchr mentioned this pull request Aug 26, 2019
Closed
10 tasks
@basvandijk
Copy link
Member Author

I think Eelco meant: Closing for: #66686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

@wizeman wizeman Awaiting requested review from wizeman

@globin globin Awaiting requested review from globin

@madjar madjar Awaiting requested review from madjar

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @edolstra @bkchr