[mojo] Add testing support to BrowserInterfaceBrokerProxy #18475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1756480
branch
from
e7c91b1
to
5e28c2d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1756480
branch
from
5e28c2d
to
780bf9a
Compare
This change adds a SetBinderForTesting() method to BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to call this new method if a script passes a new "useBrowserInterfaceBroker" parameter. Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use case for overriding interface handlers in web tests. Bug: 985118 Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#688743}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1756480
branch
from
780bf9a
to
99e5aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a SetBinderForTesting() method to
BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to
call this new method if a script passes a new "useBrowserInterfaceBroker"
parameter.
Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use
case for overriding interface handlers in web tests.
Bug: 985118
Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688743}