Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd-networkd: link: Name -> OriginalName #66703

Merged
merged 1 commit into from Aug 16, 2019
Merged

systemd-networkd: link: Name -> OriginalName #66703

merged 1 commit into from Aug 16, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member

teto commented Aug 16, 2019

could you motivate the change for those of us not systemd experts ?

@eadwu
Copy link
Member Author

eadwu commented Aug 16, 2019 •
edited

Not an expert either but I don't see Name on man systemd.link [1] and

Aug 15 22:05:28 systemd-udevd[916]: /etc/systemd/network/default.link: No valid settings found in the [Match] section. The file will match all interfaces. If that is intended, please add OriginalName=* in the [Match] section.
Aug 15 22:05:28 systemd-udevd[916]: /etc/systemd/network/default.link:2: Unknown lvalue 'Name' in section 'Match', ignoring

[1] https://manpages.debian.org/buster/udev/systemd.link.5.en.html#[MATCH]_SECTION_OPTIONS

@teto
Copy link
Member

teto commented Aug 16, 2019

I see Name in the link section and OriginalName in the Match section. I don't have this file /etc/systemd/network/default.link since I use networkmanager but the proper fix should change /etc/systemd/network/default.link to use OriginalName in the Match section rather than Name

@Mic92 Mic92 merged commit aeddf94 into NixOS:master Aug 16, 2019
@Mic92
Copy link
Member

Mic92 commented Aug 16, 2019

Backport:

[detached HEAD 776d66e] systemd-networkd: link: Name -> OriginalName
Author: Edmund Wu fangkazuto@gmail.com
Date: Thu Aug 15 21:57:52 2019 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

@eadwu eadwu mentioned this pull request Jun 29, 2020
Closed
@eadwu eadwu deleted the systemd-networkd/fix-link-field branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @teto @Mic92