Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compton: 7 -> 7.2 #66704

Merged
merged 1 commit into from Aug 24, 2019
Merged

compton: 7 -> 7.2 #66704

merged 1 commit into from Aug 24, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 16, 2019 •
edited

The git function doesn't seem to do anything, still outputting 7 from compton --version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Aug 16, 2019

@GrahamcOfBorg build compton

@jD91mZM2
Copy link
Member

I have tested this with

nix-review pr 66704

and replaced my running compton with this executable. It appears to work :)

@mmahut mmahut merged commit fce7cfc into NixOS:master Aug 24, 2019
@eadwu eadwu deleted the compton/7.2 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jD91mZM2 jD91mZM2 jD91mZM2 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @mmahut @jD91mZM2