[SyntheticModules] Allows for Fetching and Loading of JSON/Synthetic Modules #18477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1731108
branch
2 times, most recently
from
98d3fbc
to
ce13d7c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1731108
branch
2 times, most recently
from
6b64fd0
to
a4c7b44
Compare
…Modules
This is the final change required for JSON Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax:
<script type="module">
import data from "./example.json";
</script>
This change introduces several things:
-It introduces the ability for ModuleScriptLoader to load JSON Modules
-It introduces the ability for ModuleScriptFetcher to retrieve JSON resources
-It introduces a new field to ModuleScriptCreationParams: response_mime_type_
-It introduces the JSONModules runtime flag to chromium
This change corresponds with the following V8 change:
https://chromium-review.googlesource.com/c/v8/v8/+/1761583
Bug: 967018
Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688905}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1731108
branch
from
a4c7b44
to
4ff426b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final change required for JSON Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax:
<script type="module">
import data from "./example.json";
</script>
This change introduces several things:
-It introduces the ability for ModuleScriptLoader to load JSON Modules
-It introduces the ability for ModuleScriptFetcher to retrieve JSON resources
-It introduces a new field to ModuleScriptCreationParams: response_mime_type_
-It introduces the JSONModules runtime flag to chromium
This change corresponds with the following V8 change:
https://chromium-review.googlesource.com/c/v8/v8/+/1761583
Bug: 967018
Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688905}